Re: [Xen-devel] [RFC PATCH] xen/arm: Add 4-level page table for stage 2 translation

[Vijay Kilari <vijay.kilari@xxxxxxxxx>]

On Wed, Apr 30, 2014 at 6:09 PM, Julien Grall <julien.grall@xxxxxxxxxx> wrote:
> Hello Vijaya,
>
> On 04/30/2014 01:15 PM, vijay.kilari@xxxxxxxxx wrote:
>> -    first = __map_domain_page(p2m->first_level);
>> -    dump_pt_walk(first, addr);
>> -    unmap_domain_page(first);
>> +    lookup = __map_domain_page(p2m->lookup_level);
>> +    dump_pt_walk(lookup, addr);
>
> dump_pt_walk assume the table is the first level. I think you should
> update dump_pt_walk to handle the zeroeth level.

   It was misguide by dump_hyp_walk(), which is passing zeroeth level
to dump_pt_walk() for ARM64. Will update it

>>
>> -#define VADDR_BITS              32
>> -#define VADDR_MASK              (~0UL)
>> -
>
> Why did you remove VADDR_{BITS,MASK}?

  It is not used at all. at least for ARM

- Vijay

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel