Re: [Xen-devel] [PATCH v5 1/6] xen: Add convenient macro boot_cpu

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 02.05.14 at 17:52, <julien.grall@xxxxxxxxxx> wrote:
> --- a/xen/include/xen/percpu.h
> +++ b/xen/include/xen/percpu.h
> @@ -16,6 +16,9 @@
>  /* Preferred on Xen. Also see arch-defined per_cpu(). */
>  #define this_cpu(var)    __get_cpu_var(var)
>  
> +/* Access variable on boot CPU */
> +#define boot_cpu(var)   per_cpu(var, 0)
> +
>  /* Linux compatibility. */
>  #define get_cpu_var(var) this_cpu(var)
>  #define put_cpu_var(var)

I can only second Andrew's comment - without it becoming clear when
and why this would be used, this isn't going to be acceptable (and if
it really was correct and worthwhile, this small a change wouldn't need
separating out from the code that's intended to actually make use of it).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel