Re: [Xen-devel] [PATCH v5 8/9] ioreq-server: make buffered ioreq handling optional

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-05-01 at 13:08 +0100, Paul Durrant wrote:
> Some emulators will only register regions that require non-buffered
> access. (In practice the only region that a guest uses buffered access
> for today is the VGA aperture from 0xa0000-0xbffff). This patch therefore
> makes allocation of the buffered ioreq page and event channel optional for
> secondary ioreq servers.
> 
> If a guest attempts buffered access to an ioreq server that does not
> support it, the access will be handled via the normal synchronous path.
> 
> Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>

Tools portion: Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx> with one
small nit:

> diff --git a/tools/libxc/xenctrl.h b/tools/libxc/xenctrl.h
> index 74aa2bf..60f6abc 100644
> --- a/tools/libxc/xenctrl.h
> +++ b/tools/libxc/xenctrl.h
> @@ -1801,6 +1801,7 @@ int xc_get_hvm_param(xc_interface *handle, domid_t dom, 
> int param, unsigned long
>   */

IIRC there is a doc comment just above here which ought to list this new
parameter.

(those comments do fall rather into the trap of simply repeating the C
don't they, but that does appear to be the prevailing style of many of
them...)

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel