Re: [Xen-devel] [PATCH V4 10/24] libxl_json: allow basic JSON type objects generation

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

CCing Anthony.
On Thu, 2014-05-01 at 13:58 +0100, Wei Liu wrote:
> The original logic is that basic JSON types (number, string and null)
> must be an element of JSON map or array. This assumption doesn't hold
> true anymore when we need to return basic JSON types.
> 
> Returning basic JSON types is required for parsing number, string and
> null objects back into libxl__json_object.
> 
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>

I think passing (ctx->gc, obj, ctx) as arguments is a bit odd, but I can
see how it makes sense from the PoV of the conventions here (and given
that the ctx is a libxl__yajl_ctx not a libxl__ctx):

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel