Re: [Xen-devel] [PATCH V4 11/24] libxl/gentypes.py: include discriminator in JSON output

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, May 06, 2014 at 02:03:49PM +0100, Ian Campbell wrote:
> On Thu, 2014-05-01 at 13:58 +0100, Wei Liu wrote:
> > Parser relies on the discriminator to go to correct branch.
> > 
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> 
> Acked-by: Ian Campbell <ian.campbell@citrix>
> 
> But, an idea: What about calling the field which refers to the union by
> it's discriminated name, i.e. "u.pv": { map of things } instead of
> "type": "pv", "u" { map of things } ?
> 
> 

But that breaks API, doesn't it? If we can safely assume that there's no
existing user of this JSON API, changing it won't be hard.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel