Re: [Xen-devel] [PATCH V4 20/24] xl: introduce load/save_domain_config

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-05-06 at 16:03 +0100, Wei Liu wrote:
> On Tue, May 06, 2014 at 03:28:12PM +0100, Ian Campbell wrote:
> > On Thu, 2014-05-01 at 13:58 +0100, Wei Liu wrote:
> > > They are used to serialize / deserialize domain configuration to / from
> > > user data store.
> > > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > > ---
> > >  tools/libxl/xl_cmdimpl.c |  119 
> > > ++++++++++++++++++++++++++++++----------------
> > >  1 file changed, 77 insertions(+), 42 deletions(-)
> > > 
> > > diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> > > index 7443d86..f891ab5 100644
> > > --- a/tools/libxl/xl_cmdimpl.c
> > > +++ b/tools/libxl/xl_cmdimpl.c
> > > @@ -160,6 +160,73 @@ struct domain_create {
> > >      char **migration_domname_r; /* from malloc */
> > >  };
> > >  
> > > +static int _parse_config_data_json(char *config_data, int config_len,
> > > +                                   libxl_domain_config *d_config)
> > 
> > The _ namespace is reserved for something (either POSIX or the compiler,
> > but not us, for sure)
> > 
> 
> I will use _xl namespace instead.

Anything starting with _ is reserved. xl_foo would be fine, in the
context of a static function parse_config_data_json would also be fine.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel