Re: [Xen-devel] [PATCH V4 01/24] xl / libxl: push parsing of SSID and CPU pool ID down to libxl

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, May 07, 2014 at 10:50:58AM +0100, Ian Campbell wrote:
> On Tue, 2014-05-06 at 14:03 +0100, Wei Liu wrote:
> > > > +    size_t size;
> > > > +
> > > >      memcpy(&(xlinfo->uuid), xcinfo->handle, 
> > > > sizeof(xen_domain_handle_t));
> > > >      xlinfo->domid = xcinfo->domain;
> > > >      xlinfo->ssidref = xcinfo->ssidref;
> > > > +    if (libxl_flask_sid_to_context(ctx, xlinfo->ssidref,
> > > > +                                   &xlinfo->ssid_label, &size) < 0)
> > > > +        xlinfo->ssid_label = NULL;
> > > 
> > > Is this a critical error?
> > > 
> > 
> > I'm not very sure about this. My thought was that not displaying the
> > name of the label is not critical, but on the other hand you can argue
> > that showing incorrect information is just wrong...
> 
> Isn't this used when roundtripping things through the JSON though --
> i.e. lookup the name and then reparse on the other end? If you fail to
> do the lookup -> boom?
> 

No. This is only used for showing information, not for domain creation.
So it seems less critical to me.

Wei.

> Are there circumstances where it is expected that it isn't possible to
> translate an ssid ref back to a name? Perhaps if it has been deleted
> since the guest was created? If there isn't such a possibility then that
> would argue for it being an error. (Maybe this is one for Daniel)
> 
> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel