Re: [Xen-devel] [PATCH v4 09/15] autoconf: xen: force a refresh with autoconf

[Roger Pau Monnà <roger.pau@xxxxxxxxxx>]

On 07/05/14 18:21, Ian Campbell wrote:
> On Wed, 2014-05-07 at 18:12 +0200, Roger Pau Monnà wrote:
>> On 30/04/14 03:12, Luis R. Rodriguez wrote:
>>> From: "Luis R. Rodriguez" <mcgrof@xxxxxxxx>
>>>
>>> With some new functionality introduced we can't keep around the old cache.
>>>
>>> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
>>> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
>>> Cc: Jan Beulich <jbeulich@xxxxxxxx>
>>> Cc: Keir Fraser <keir@xxxxxxx>
>>> Cc: Tim Deegan <tim@xxxxxxx>
>>> Signed-off-by: Luis R. Rodriguez <mcgrof@xxxxxxxx>
>>> ---
>>>  autogen.sh | 8 ++++----
>>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/autogen.sh b/autogen.sh
>>> index b5c9688..2be8360 100755
>>> --- a/autogen.sh
>>> +++ b/autogen.sh
>>> @@ -1,12 +1,12 @@
>>>  #!/bin/sh -e
>>> -autoconf
>>> +autoconf -f
>>>  ( cd tools
>>> -  autoconf
>>> +  autoconf -f
>>>    autoheader
>>>  )
>>>  ( cd stubdom
>>> -  autoconf
>>> +  autoconf -f
>>>  )
>>>  ( cd docs
>>> -  autoconf
>>> +  autoconf -f
>>>  )
>>
>> Not that is that important, but why do you need to force the regen of
>> all files? I expect autoconf should be able to detect which files need
>> rebuilding.
> 
> I've observed it not doing so, when I thought it should, I never figured
> out why and/or if I was mistaken though

I have not seen this myself, but if it's the case (and provided that the
commit message is reworded to reflect this):

Acked-by: Roger Pau Monnà <roger.pau@xxxxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel