[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v6 05/10] Clear AC bit in RFLAGS to protect Xen itself by SMAP



>>> On 08.05.14 at 04:02, <feng.wu@xxxxxxxxx> wrote:
>> From: Andrew Cooper [mailto:amc96@xxxxxxxxxxxxxxxx] On Behalf Of
>> I am not fussed where exactly the STAC goes in the entry point, but
>> don't leave a CLAC in the SAVE_ALL.
> 
> Sure, thanks for the suggestion! I will pass 0 to SAVE_ALL. 
> My point is that ASM_STAC should be deferred as much as possible.

There's no point in deferring it as much as possible if you don't CLAC
earlier on. In fact I'm inclined to ask to make the SAVE_ALL parameter
a tristate, allowing both CLAC and STAC to be done right there.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.