Re: [Xen-devel] [PATCH v2 3/3] tmem: fix Out-of-bounds read reported by Coverity

[Bob Liu <bob.liu@xxxxxxxxxx>]

On 05/07/2014 04:33 PM, Jan Beulich wrote:
>>>> On 07.05.14 at 08:30, <lliubbo@xxxxxxxxx> wrote:
>> CID 1198729, CID 1198730 and CID 1198734 complain about
>> "Out-of-bounds read".
>>
>> This patch fixes them by casting the 'firstbyte' to (uint8_t), some
>> unnecessary assertion also be dropped.
>>
>> Signed-off-by: Bob Liu <bob.liu@xxxxxxxxxx>
>> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> 
> It looks to me as if the code was more correct without these changes,
> and doing these changes just to work around a pretty obvious
> Coverity flaw seems rather odd.
> 

Okay, then please consider merge 1/3 and 2/3.

-- 
Regards,
-Bob

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel