Re: [Xen-devel] [PATCH v6] Autoconf: add variable for pass arbitrary options to qemu upstream

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-05-06 at 16:30 +0200, Fabio Fantoni wrote:
> Added configure options for pass arbitrary build options to qemu
> upstream.
> 
> Usage example:
> ./configure QEMUU_EXTRA_ARGS="--enable-spice --enable-usb-redir"

Isn't
        ./configure --with-extra-qemuu-configure-args="--enable-sss"
more conventional for this sort of thing?

> diff --git a/config/Tools.mk.in b/config/Tools.mk.in
> index 18f3b8a..0693c03 100644
> --- a/config/Tools.mk.in
> +++ b/config/Tools.mk.in
> @@ -55,6 +55,7 @@ CONFIG_QEMU_TRAD    := @qemu_traditional@
>  CONFIG_QEMU_XEN     := @qemu_xen@
>  CONFIG_BLKTAP1      := @blktap1@
>  CONFIG_VTPM         := @vtpm@
> +CONFIG_QEMUU_EXTRA_ARGS:= @QEMUU_EXTRA_ARGS@

Please insert the word "CONFIGURE" somewhere so we know what the args
are for.

> diff --git a/tools/configure.ac b/tools/configure.ac
> index 00fb47b..16ca790 100644
> --- a/tools/configure.ac
> +++ b/tools/configure.ac
> @@ -141,6 +141,7 @@ AC_ARG_VAR([AS86], [Path to as86 tool])
>  AC_ARG_VAR([LD86], [Path to ld86 tool])
>  AC_ARG_VAR([BCC], [Path to bcc tool])
>  AC_ARG_VAR([IASL], [Path to iasl tool])
> +AC_ARG_VAR([QEMUU_EXTRA_ARGS], [List of upstream qemu additionals build 
> paramters])

"List of additional configure options for upstream qemu"

>  
>  # Checks for programs.
>  AC_PROG_CC



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel