Re: [Xen-devel] [PATCH] clarify SHUTDOWN_suspend additional argument

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2014-05-07 at 14:05 +0100, Stefano Stabellini wrote:
> SCHEDOP_shutdown has a third argument that is unused on HVM and ARM
> guests. Those guests pass 0 instead. Clarify the behaviour in the
> hypercall description.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

But:
> diff --git a/xen/include/public/sched.h b/xen/include/public/sched.h
> index a30b11d..c170556 100644
> --- a/xen/include/public/sched.h
> +++ b/xen/include/public/sched.h
> @@ -77,8 +77,9 @@
>   * @arg == pointer to sched_shutdown_t structure.
>   *
>   * If the sched_shutdown_t reason is SHUTDOWN_suspend then this
> - * hypercall takes an additional extra argument which should be the
> - * MFN of the guest's start_info_t.
> + * hypercall takes an additional extra argument which should be:
> + *  - the MFN of the guest's start_info_t for x86 PV guests;
> + *  - 0 for x86 HVM guests and arm and arm64 guests.

Is this strictly true or is the argument ignored for those guests?
(Requiring it to be zero doesn't conflict with that hence the ack)

>   *
>   * In addition, which reason is SHUTDOWN_suspend this hypercall
>   * returns 1 if suspend was cancelled or the domain was merely



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel