Re: [Xen-devel] [PATCH v6 6/9] Add an option to limit ranges per rangeset

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> Sent: 08 May 2014 16:04
> To: Paul Durrant
> Cc: xen-devel@xxxxxxxxxxxxx; Keir (Xen.org)
> Subject: Re: [PATCH v6 6/9] Add an option to limit ranges per rangeset
> 
> >>> On 08.05.14 at 15:23, <paul.durrant@xxxxxxxxxx> wrote:
> >  xen/arch/x86/domain.c      |    2 +-
> >  xen/arch/x86/mm/p2m.c      |    2 +-
> >  xen/arch/x86/setup.c       |    2 +-
> >  xen/common/domain.c        |    5 ++--
> 
> The patch wouldn't need to touch all these files had you followed the
> advice and added a new rangeset function allowing to set the limit on
> an existing (perhaps empty) rangeset.
> 

Ok. I thought adding an extra arg would be preferable. Clearly not, so I'll go 
for the extra call you suggest.

> > --- a/xen/common/rangeset.c
> > +++ b/xen/common/rangeset.c
> > @@ -25,6 +25,8 @@ struct rangeset {
> >
> >      /* Ordered list of ranges contained in this set, and protecting lock.
> > */
> >      struct list_head range_list;
> > +    unsigned int     nr_ranges;
> > +    unsigned int     max_nr_ranges;
> 
> And I think you should aim at getting away with just one added
> variable (number of ranges still permitted to be added).

Ok.

  Paul

> 
> Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel