Re: [Xen-devel] [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

["Gonglei (Arei)" <arei.gonglei@xxxxxxxxxx>]

> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> Sent: Friday, May 09, 2014 5:36 PM
> To: Gonglei (Arei)
> Cc: anthony.perard@xxxxxxxxxx; Ian.Campbell@xxxxxxxxxx;
> stefano.stabellini@xxxxxxxxxxxxx; johannes.krampf@xxxxxxxxxxxxxx; Gaowei
> (UVP); Hanweidong (Randy); Huangweidong (C); kevin@xxxxxxxxxxxx;
> fabio.fantoni@xxxxxxx; qemu-devel@xxxxxxxxxx; mst@xxxxxxxxxx
> Subject: Re: [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0 methods
> for PCIslots that support hotplug by runtime patching
> 
> >>> On 09.05.14 at 10:47, <arei.gonglei@xxxxxxxxxx> wrote:
> > From: Gonglei <arei.gonglei@xxxxxxxxxx>
> >
> > In Xen platform, after using upstream qemu, the all of pci devices
> > will show hotplug in the windows guest, no matter whether they can
> > be hotpluged. It is unfriendly. The PCI devices that can not be
> > hotpluged are hidden by modifing the DSDT entries of PCI slots when runtime.
> >
> > This is done by:
> >  - Rename _EJ0 methods for PCI slots in DSDT to EJ0_:note that
> >    this has the same checksum, but is ignored by OSPM.
> >  - At compile time, look for these methods in ASL source,
> >    find the matching AML, and store the offsets of these methods
> >    in a table named aml_ej0_data.
> >  - At run time, go over aml_ej0_data, check which slots not support
> >    hotplug and patch the ACPI table, replacing _EJ0 with EJ0_.
> 
> I think you mistakenly sent this to qemu-devel instead of xen-devel.

Yep, that's my fault.

> And it also seem pretty pointless to send a v4 without addressing
> all comments you got on v3.
> 
I don't think so. I have absorbed Ian's all suggestion on v3. And for other 
questions have been answered too, in despite of is me or not.


Best regards,
-Gonglei

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel