Re: [Xen-devel] [RFC v3 3/6] xen/arm: Add save/restore support for ARM arch timer

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Wei,

Thank you for the patch.

On 08/05/14 22:18, Wei Huang wrote:
> +    switch ( ctxt.type )
> +    {
> +    case ARM_TIMER_TYPE_PHYS:
> +        t = &v->arch.phys_timer;
> +        d->arch.phys_timer_base.offset = ctxt.vtb_offset;
> +        break;
> +    case ARM_TIMER_TYPE_VIRT:
> +        t = &v->arch.virt_timer;
> +        d->arch.virt_timer_base.offset = ctxt.vtb_offset;
It seems you forgot to address some of my comments on the timer 
save/restore.
Saving {virt,phys}_timer_base.offset per VCPU rather than per-domain 
seems a waste of space and confusing.
Furthermore, this offset is used to get a relative offset from the Xen 
timer counter. Migrating the guess to another server will invalidate the 
value.
Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel