Re: [Xen-devel] [PATCH] xen: arm: bitops take unsigned int (Was: Re: [PATCH] xen/arm64: disable alignment check)

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Mon, 12 May 2014, Ian Campbell wrote:
> On Sun, 2014-05-11 at 19:34 +0100, Stefano Stabellini wrote:
> > On Fri, 9 May 2014, Ian Campbell wrote:
> > > (Just adding the other ARM guys...)
> > > 
> > > On Fri, 2014-05-09 at 14:24 +0100, Ian Campbell wrote:
> > > > On Tue, 2014-04-29 at 09:58 +0100, Ian Campbell wrote:
> > > > > On Tue, 2014-04-29 at 08:38 +0100, Vladimir Murzin wrote:
> > > > > > On Mon, Apr 28, 2014 at 11:43 AM, Ian Campbell 
> > > > > > <Ian.Campbell@xxxxxxxxxx> wrote:
> > > > > > > But I also wanted confirmation that the problematic instruction 
> > > > > > > was
> > > > > > > generated by gcc and not by some handcoded asm somewhere which we 
> > > > > > > hadn't
> > > > > > > properly fixed.
> > > > > 
> > > > > > I believe it comes form test_bit (xen/include/asm-arm/bitops.h).
> > > > > 
> > > > > Ah, then I think this code needs fixing too. Probably switching to
> > > > > unsigned int * throughout would work, what do you think?
> > > > 
> > > > I finally managed to upgrade to a new enough kernel to trigger this.
> > > > 
> > > > This Works For Me(tm), along with the Linux patch "xen/events/fifo:
> > > > correctly align bitops" which is queued for 3.15 Linus (but not sent
> > > > yet?)
> > 
> > The change looks good to me.
> 
> Are you acking it?

Yes

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel