Re: [Xen-devel] [libvirt test] 26144: tolerable FAIL - PUSHED

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Jackson writes ("Re: [Xen-devel] [libvirt test] 26144: tolerable FAIL - 
PUSHED"):
> Ian Campbell writes ("Re: [Xen-devel] [libvirt test] 26144: tolerable FAIL - 
> PUSHED"):
> > On Sun, 2014-05-04 at 18:29 +0100, xen.org wrote:
> > > People who touched revisions under test:
> > 
> > [...snip an empty list...]
> > 
> > But:
> > $ git log --oneline 
> > 064f49a0507ad5239c5f5bc954a48c59950b9225..791fb3f6687ca3f0eb3f0b7228f2a0c688c2b1cc
> > 791fb3f Release of libvirt-1.2.4
> > 4bdb503 Explicitly link virfirewalltest and virsystemdtest against dbus
> > 3cee4c0 qemuxml2argvtest: Don't use privileged mode upfront
> > $
> > 
> > Strange?
> 
> adhoc-revtuple-generator seems to work right now.  I can't explain
> this and sadly the relevant set -x output log (cr-for-branches.log)
> has expired.

This happened again in 26227.  Investigation reveals that the only
change there was 77e7a75a8b505e8c46630b4c279aec13fc26a464 which has no
s-o-b.

We need to fix adhoc-people-touched-filter.

Ian.

From b1014d809436074dee817de32012fb0f2d9e2603 Mon Sep 17 00:00:00 2001
From: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Date: Mon, 12 May 2014 14:36:10 +0100
Subject: [OSSTEST PATCH] adhoc-people-touched-filter: Include patch authors

The git "Author:" tag of each commit should be included.

(We used to include only special pseudo-headers from the patch
comment, because the old hg practice used to be to put the committer
in the hg commit author.  But git separates committer and author.)

This involves a slight refactoring.

Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
---
 adhoc-people-touched-filter |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/adhoc-people-touched-filter b/adhoc-people-touched-filter
index 3dcce53..1142dfb 100755
--- a/adhoc-people-touched-filter
+++ b/adhoc-people-touched-filter
@@ -20,9 +20,10 @@
 use strict qw(refs vars);
 our %show;
 while (<>) {
-    next unless s/^    //;
-    next unless s/^(signed-off-by|tested-by|acked-by|committed-by|from):\s+//i;
-    $show{lc $_}= $_;
+    if (s/^    (signed-off-by|tested-by|acked-by|committed-by|from):\s+//i
+       || s/^author:\s+//i) {
+       $show{lc $_}= $_;
+    }
 }
 foreach my $k (sort keys %show) {
     print "  ", $show{$k} or die $!;
-- 
1.7.10.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel