Re: [Xen-devel] [PATCH v5] libxl: add option for discard support to xl disk configuration

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Olaf Hering writes ("[PATCH v5] libxl: add option for discard support to xl 
disk configuration"):
> Handle new boolean option discard/no-discard for disk configuration. It
> is supposed to disable discard support if file based backing storage was
> intentionally created non-sparse to avoid fragmentation of the file.
> 
> The option intended for the backend driver. A new boolean property
> "discard-enable" is written to the backend node. An upcoming patch for
> qemu will make use of this property. The kernel blkback driver may be
> updated as well to disable discard for phy based backing storage.

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

> +discard / no-discard
> +---------------
> +
> +Description:           Request backend to advertise discard support to 
> frontend

I have one tiny comment, which is that slightly better English grammar
here would be "Request that backend advertise".  If Ian C agrees then
we should make this change as we commit it.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel