Re: [Xen-devel] [RFC v3 0/6] xen/arm: ARM save/restore/migration support

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2014-05-12 at 09:52 -0500, Wei Huang wrote:
> On 05/12/2014 09:17 AM, Julien Grall wrote:
> > Hi Wei,
> >
> > On 05/08/2014 10:18 PM, Wei Huang wrote:
> >> The following patches enable save/restore/migration support for ARM
> >> guest VMs. Note that the original series were sent from Jaeyong Yoo.
> >>
> >> Working:
> >>     * 32-bit (including SMP) guest VM save/restore/migration
> >>     * 64-bit guest VM save
> >> WIP:
> >>     * 64-bit guest restore/migration
> >
> > I though a bit more about this series. I think we miss to save the
> > layout of the guest (i.e GIC base address, gnttab base address,...) and
> > some interrupts (i.e timer, evtchn,...)
> >
> > It's necessary because if we migrate from a older Xen to a new Xen, the
> > default layout may have change.
> >
> Should we make these requirements as phase 2 for save/restore/migration? 
> I think we have enough items to fix in current form. Adding more 
> requirements will make the whole patch set bloated and hard to revise.

It would probably be reasonably easy to add the save bit and to just
assert on restore that the address is the one we support.

But equally it would be possible to default to the current value on
restore if no contrary save record is found, meaning we can fix it then.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel