[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH OSSTEST RFC v2 1/2] Add a flight to test qemu.org's ("mainline") master branch.



On Mon, 2014-05-12 at 16:21 +0100, Ian Campbell wrote:
> > > diff --git a/cri-common b/cri-common
> > > index d82312c..d901383 100644
> > > --- a/cri-common
> > > +++ b/cri-common
> > > @@ -43,6 +43,7 @@ repo_tree_rev_fetch_git () {
> > >  select_xenbranch () {
> > >   case "$branch" in
> > >   xen*)                   tree=xen;       xenbranch=$branch ;;
> > > + qemu-mainline)          tree=qemuu;     xenbranch=xen-unstable  
> > > qemuubranch=qemu-mainline;;
> > >          qemu-upstream-*)    tree=qemuu; 
> > > xenbranch=xen-${branch#qemu-upstream-};;
> > >   linux)                  tree=linux;     xenbranch=xen-unstable ;;
> > >   linux-*)                tree=linux;     xenbranch=xen-unstable ;;
> > > @@ -55,6 +56,9 @@ select_xenbranch () {
> > >   else
> > >           linuxbranch=''
> > >   fi
> > > + if [ x$qemuubranch = x ]; then
> > > +         qemuubranch="qemu-upstream-${xenbranch#xen-}"
> > > + fi
> > 
> > Perhaps it would be easier to move the default setting of qemuubranch
> > above the case, where it wouldn't need to be conditional.
> 
> Yes, good suggestion.

Actually no: It uses $xenbranch which is set by the case.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.