Re: [Xen-devel] [PATCH v4 08/15] tools/xendomains: move to libexec and use a smaller init helper

["Luis R. Rodriguez" <mcgrof@xxxxxxxx>]

On Wed, May 07, 2014 at 04:24:20PM +0100, Ian Campbell wrote:
> On Tue, 2014-04-29 at 18:12 -0700, Luis R. Rodriguez wrote:
> > From: "Luis R. Rodriguez" <mcgrof@xxxxxxxx>
> > 
> > The xendomains script can be reused with systemd systems as it
> > does not control services or sockets per se, but does a one shot
> > scrape of domUs it needs start bring up, stop, reload so we're
> > going to reuse it. This moves the core of the script to libexec
> > and leaves only a helper on init.
> > 
> > Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> > Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > Cc: Jan RÄkorajski <baggins@xxxxxxxxxxxxx>
> > Cc: M A Young <m.a.young@xxxxxxxxxxxx>
> > Cc: Jacek Konieczny <jajcus@xxxxxxxxxx>
> > Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx
> > Signed-off-by: Luis R. Rodriguez <mcgrof@xxxxxxxx>
> > ---
> >  tools/hotplug/Linux/Makefile          |   6 +
> >  tools/hotplug/Linux/init.d/xendomains | 567 
> > +-------------------------------
> >  tools/hotplug/Linux/xendomains        | 585 
> > ++++++++++++++++++++++++++++++++++
> 
> Did you use the -M option here?

I always do, hence my original concern -- but we determined last that even
though the output did not show the move the commit does, so I think we're
good. Will be good to follow up on the possible discprepancy with upstreamg
git though.

> > @@ -45,6 +46,11 @@ install: all install-initd install-scripts install-udev
> >  install-initd:
> >     [ -d $(DESTDIR)$(INITD_DIR) ] || $(INSTALL_DIR) $(DESTDIR)$(INITD_DIR)
> >     [ -d $(DESTDIR)$(SYSCONFIG_DIR) ] || $(INSTALL_DIR) 
> > $(DESTDIR)$(SYSCONFIG_DIR)
> > +   [ -d $(DESTDIR)$(LIBEXEC) ] || $(INSTALL_DIR) $(DESTDIR)$(LIBEXEC)
> > +ifeq ($(CONFIG_XEND),y)
> > +   $(INSTALL_PROG) $(XEND_INITD) $(DESTDIR)$(INITD_DIR)
> 
> With xend's removal this can now go.

Done.

> 
> > +endif
> > +   $(INSTALL_PROG) $(XENDOMAINS_LIBEXEC) $(DESTDIR)$(LIBEXEC)
> >     $(INSTALL_PROG) $(XENDOMAINS_INITD) $(DESTDIR)$(INITD_DIR)
> >     $(INSTALL_DATA) $(XENDOMAINS_SYSCONFIG) 
> > $(DESTDIR)$(SYSCONFIG_DIR)/xendomains
> >     $(INSTALL_PROG) $(XENCOMMONS_INITD) $(DESTDIR)$(INITD_DIR)
> > diff --git a/tools/hotplug/Linux/init.d/xendomains 
> > b/tools/hotplug/Linux/init.d/xendomains
> > index 587568d..d0122fc 100644
> > --- a/tools/hotplug/Linux/init.d/xendomains
> > +++ b/tools/hotplug/Linux/init.d/xendomains
> 
> I think I need to apply the series and examine with git to figure out
> what changed here, which I'll do another time.

Better try my next series.

  Luis

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel