Re: [Xen-devel] [RFC v3 5/6] xen/arm: Add log_dirty support for ARM

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 05/14/2014 12:57 PM, Ian Campbell wrote:
>>> @@ -341,6 +343,27 @@ static inline void put_page_and_type(struct page_info 
>>> *page)
>>>       put_page(page);
>>>   }
>>>
>>> +enum mg { mg_clear, mg_ro, mg_rw, mg_rx };
>>
>> Please describe this enum. Also mg is too generic.
> 
> This is just code motion.

This enum has been moved in a header which is included everywhere.

Keeping the name "mg" without any description is confusion. Developper
can misuse this enum.

>>> @@ -41,6 +42,7 @@ typedef enum {
>>>       p2m_invalid = 0,    /* Nothing mapped here */
>>>       p2m_ram_rw,         /* Normal read/write guest RAM */
>>>       p2m_ram_ro,         /* Read-only; writes are silently dropped */
>>> +    p2m_ram_logdirty,   /* Read-only: special mode for log dirty */
>>
>> You should at the new type at the end of the enum.
> 
> Why? Keeping p2m_ram_* together doesn't seem wrong to me.

My mistake, I though we store the P2M during the migration.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel