Re: [Xen-devel] [RFC v3 6/6] xen/arm: Implement toolstack for xl restore/save/migration

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-05-08 at 16:18 -0500, Wei Huang wrote:
> This patch implements xl save/restore operation in xc_arm_migrate.c
> and make it compilable with existing design. The operation is also
> used by migration.
> 
> The overall process of save/restore is the following: 1) save guest
> parameters; 2) save memory; 3) save HVM states.
> 
> Signed-off-by: Alexey Sokolov <sokolov.a@xxxxxxxxxxx>
> Signed-off-by: Wei Huang <w1.huang@xxxxxxxxxxx>

I'm going to defer reviewing this for now, it'll likely need to be
reworked to fit into Andy's new migration framework. As I mentioned
before (I think/hope!) I'd like ARM to use that from day 1.

> diff --git a/tools/misc/Makefile b/tools/misc/Makefile
> index 69b1817..f4ea7ab 100644
> --- a/tools/misc/Makefile
> +++ b/tools/misc/Makefile

This change could probably be refactored into a separate patch and
applied already.

> @@ -11,7 +11,7 @@ HDRS     = $(wildcard *.h)
>  
>  TARGETS-y := xenperf xenpm xen-tmem-list-parse gtraceview gtracestat 
> xenlockprof xenwatchdogd xencov
>  TARGETS-$(CONFIG_X86) += xen-detect xen-hvmctx xen-hvmcrash xen-lowmemd 
> xen-mfndump
> -TARGETS-$(CONFIG_MIGRATE) += xen-hptool
> +TARGETS-$(CONFIG_X86) += xen-hptool
>  TARGETS := $(TARGETS-y)
>  
>  SUBDIRS := $(SUBDIRS-y)
> @@ -23,7 +23,7 @@ INSTALL_BIN := $(INSTALL_BIN-y)
>  INSTALL_SBIN-y := xen-bugtool xen-python-path xenperf xenpm 
> xen-tmem-list-parse gtraceview \
>       gtracestat xenlockprof xenwatchdogd xen-ringwatch xencov
>  INSTALL_SBIN-$(CONFIG_X86) += xen-hvmctx xen-hvmcrash xen-lowmemd xen-mfndump
> -INSTALL_SBIN-$(CONFIG_MIGRATE) += xen-hptool
> +INSTALL_SBIN-$(CONFIG_X86) += xen-hptool
>  INSTALL_SBIN := $(INSTALL_SBIN-y)
>  
>  INSTALL_PRIVBIN-y := xenpvnetboot



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel