Re: [Xen-devel] libxl: default behavior when libxl fail to map an IRQ

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 05/14/2014 05:43 PM, Ian Campbell wrote:
> On Wed, 2014-05-14 at 17:34 +0100, Julien Grall wrote:
>> Hello all,
>>
>> It seems that libxl continue to create the domain even when the function
>> domcreate_launch (tools/libxl/libxl_create.c) fails to map an IRQ to a
>> domain.
>>
>> I looked at the code and libxl only prints an error message when an
>> error occurred. It's the same thing for MMIO and ioport.
>>
>> Shouldn't we stop to create the domain when something is failing?
> 
> yeah, it seems like all three of those loops are missing a goto
> error_out.

Thanks for you answer. I will write a patch to add a goto in theses loop.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel