Re: [Xen-devel] [PATCH V5 04/32] libxl: libxl_uuid_copy now taks a ctx argument

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, May 16, 2014 at 11:30:52AM +0100, Ian Campbell wrote:
> On Fri, 2014-05-16 at 11:18 +0100, Wei Liu wrote:
> > On Fri, May 16, 2014 at 10:46:52AM +0100, Ian Campbell wrote:
> > > On Thu, 2014-05-15 at 18:13 +0100, Wei Liu wrote:
> > > 
> > > > > > +typedef struct libxl__ctx libxl_ctx;
> > > > > 
> > > > > Maybe libxl_uuid.h should include libxl.h?
> > > > > 
> > > > 
> > > > That leads to circular inclusion.
> > > 
> > > Do the #define guards not solve that? 
> > > 
> > > Or do you mean that libxl.h's include of libxl_uuid.h might be before
> > > libxl_ctx is typedefd?
> > > 
> > 
> > The latter. libxl includes libxl_uuid.h at the beginning.
> 
> Is reordering the typedef wrt that an option?
> 

Moving typedef before including libxl_FOO.h does the job, I think.

Wei.

> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel