Re: [Xen-devel] `xl create` can not parse `disk = ['target=/tmp/disk.img, vdev=xvdb']`

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-05-16 at 10:48 -0400, Zhigang Wang wrote:
> On 05/16/2014 10:18 AM, Ian Campbell wrote:
> > On Fri, 2014-05-16 at 10:14 -0400, Zhigang Wang wrote:
> >> Hi,
> >>
> >> `xl create` cannot parse::
> >>
> >>     disk = ['target=/tmp/disk.img,vdev=xvdb']
> >>
> >> Error::
> >>
> >>     # xl create vm.cfg 
> >>     Parsing config from vm.cfg
> >>     vm.cfg: config parsing error in disk specification: no vdev specified 
> >> in `target=/tmp/disk.img,vdev=xvdb'
> >>
> >> But can parse::
> >>
> >>     disk = ['vdev=xvdb,target=/tmp/disk.img']
> >>
> >> Is this a bug?
> > 
> > No, it is expected, check the docs for the disk format strings.
> > 
> > (User questions should go to xen-users@)
> 
> Thanks for your answer.
> 
> I checked: 
> http://xenbits.xen.org/docs/4.4-testing/misc/xl-disk-configuration.txt
>  
> And I think here is what you referred to:
> 
>     where each diskspec is in this form:
>         
>        [<key>=<value>|<flag>,]*,
>          [<target>, [<format>, [<vdev>, [<access>]]]],
>          [<key>=<value>|<flag>,]*
>          [target=<target>]
> 
> That means disk positional parameter also has orders.

Well, yes, that's what positional means.

>  I missed this point before.

More importantly you are apparently still missing:

        When this parameter is specified by name, ie with the "target="
           syntax in the configuration file, it consumes the whole rest of the
           <diskspec> including trailing whitespaces.  Therefore in that case
           it must come last

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel