Re: [Xen-devel] [PATCHv3 net] xen-netback: fix race between napi_complete() and interrupt handler

[David Miller <davem@xxxxxxxxxxxxx>]

From: David Vrabel <david.vrabel@xxxxxxxxxx>
Date: Fri, 16 May 2014 12:26:04 +0100

> Dave, can you take this instead:
> 
> 8<--------------
> xen-netback: fix race between napi_complete() and interrupt handler
> 
> When the NAPI budget was not all used, xenvif_poll() would call
> napi_complete() /after/ enabling the interrupt.  This resulted in a
> race between the napi_complete() and the napi_schedule() in the
> interrupt handler.  The use of local_irq_save/restore() avoided by
> race iff the handler is running on the same CPU but not if it was
> running on a different CPU.
> 
> Fix this properly by calling napi_complete() before reenabling
> interrupts (in the xenvif_napi_schedule_or_enable_irq() call).
> 
> Signed-off-by: David Vrabel <david.vrabel@xxxxxxxxxx>
> Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Applied, thanks everyone.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel