Re: [Xen-devel] [PATCH v6 03/19] x86/VPMU: Minor VPMU cleanup

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 19.05.14 at 17:35, <boris.ostrovsky@xxxxxxxxxx> wrote:
> On 05/19/2014 10:26 AM, Jan Beulich wrote:
>>>>> On 13.05.14 at 17:53, <boris.ostrovsky@xxxxxxxxxx> wrote:
>>> Update macros that modify VPMU flags to allow changing multiple bits at 
> once.
>>>
>>> Make sure that we only touch MSR bitmap on HVM guests (both VMX and SVM).
>>> This is needed by subsequent PMU patches.
>> This part is at least questionable - why would these bitmaps not
>> similarly be used by PVH? And if so, this second change is kind of
>> a policy one, while the first change is a purely mechanical one. I.e.
> 
> 
> At this patch PVH VPMU won't work at all, bitmaps or not. It is enabled 
> in patch 18 and there I replace is_hvm_domain() with 
> has_hvm_container_domain(). I didn't want to do this here so that 
> PVH-related changes are more explicit in 18.

Okay, that's extra churn, but fine with me as long as you add a brief
comment to the patch description saying why this is being done that
way (to avoid the same question popping up again).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel