Re: [Xen-devel] [PATCH 3/5] hotplug/linux: Improve iptables logic

[Sylvain Munaut <s.munaut@xxxxxxxxxxxxxxxxxxxx>]

Hi,


> And here the redundant rules are dropped and the rest are reordered
> slightly, which again I think/suppose is safe.

Yes, it is. Because the rules have no overlap (i.e if one matches, the
other won't).

I use -A instead of -I (to append rather than insert).

_HOWEVER_ I just realized that it had another impact which is to add
the rules at the end of the chain rather than at the beginning which
will significantly change things if people have other rules in there.
So I'll change back to using -I and change the logic a bit to handle
this properly.

Damn, I almost missed that ...


Cheers,

    Sylvain

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel