Re: [Xen-devel] [PATCH V5 28/32] libxl: store up-to-date domain configuration as we create domain

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Wei Liu writes ("[PATCH V5 28/32] libxl: store up-to-date domain configuration 
as we create domain"):
> This patch utilizes "libxl-json" format and helper functions introduced
> in previous patch to store up-to-do domain configuration when creating a
> domain.

This looks like it's going in the right direction.  I agree with Ian
C's comments.

Also:

> @@ -814,6 +819,16 @@ static void initiate_domain_create(libxl__egc *egc,
>      dcs->guest_domid = domid;
>      dcs->dmss.dm.guest_domid = 0; /* means we haven't spawned */
>  
> +    /* At this point we've got domid and UUID, store configuration */
> +    ret = libxl_store_domain_configuration(ctx, domid, &d_config_saved);
> +    if (ret) {
> +        LIBXL__LOG(ctx, LIBXL__LOG_ERROR, "cannot store domain 
> configuration: %d",

This line needs wrapping.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel