Re: [Xen-devel] [PATCH V5 01/32] libxl: make cpupool_qualifier_to_cpupoolid a library function

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, May 20, 2014 at 03:47:42PM +0100, Ian Jackson wrote:
> Ian Campbell writes ("Re: [PATCH V5 01/32] libxl: make 
> cpupool_qualifier_to_cpupoolid a library function"):
> > On Tue, 2014-05-13 at 22:53 +0100, Wei Liu wrote:
> > > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > 
> > Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > 
> > I'm unsure whether additions to libxl_utils.h should have a
> > corresponding #define LIBXL_HAVE.
> 
> Yes, I think they probably should.
> 

I will have the following snippet in libxl.h

/* LIBXL_HAVE_CPUPOOL_QUALIFIER_TO_CPUPOOLID
 *
 * If this is defined, libxl has a library function called
 * libxl_cpupool_qualifier_to_cpupoolid, which takes in a CPU pool
 * qualifier in the form of number or string, then returns the ID of
 * that CPU pool.
 */
#define LIBXL_HAVE_CPUPOOL_QUALIFIER_TO_CPUPOOLID 1

Do you think it is OK? Can I retain Ian's ack?

Wei.

> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel