Re: [Xen-devel] libcacard is been installed to /usr/lib while libdir=/usr/lib64

[Zhigang Wang <zhigang.x.wang@xxxxxxxxxx>]

On 05/21/2014 06:50 AM, Olaf Hering wrote:
> On Wed, May 21, Ian Campbell wrote:
> 
>> On Wed, 2014-05-21 at 09:46 +0200, Olaf Hering wrote:
>>> On Tue, May 20, Zhigang Wang wrote:
>>>
>>>> +++ b/tools/Makefile
>>>> @@ -188,11 +188,14 @@ subdir-all-qemu-xen-dir: qemu-xen-dir-find
>>>>    $$source/configure --enable-xen --target-list=i386-softmmu \
>>>>            $(QEMU_XEN_ENABLE_DEBUG) \
>>>>            --prefix=$(PREFIX) \
>>>
>>> Looks ok to me. You may want to change also --prefix to $PREFIX/lib/xen
>>> with this patch
>>
>> I think it would be nice to get our special qemu build out of general
>> $PATH. Ian J -- do you agree?
>>
>>>  and see if anything needs adjustment.
>>
>> libxl certainly will I think, in qemu_xen_path at least
> 
> This is already handled by --bindir=, the "if anything needs adjustment"
> means most likely data and /etc paths. But then, qemu is supposed to
> cope with any --prefix= so I guess the different prefix will just work.

Here is my test result with attached patch:

1. qemu_helperdir = libexecdir = $prefix/libexec moves. Affection: 
/usr/libexec/qemu-bridge-helper moves to 
/usr/lib/xen/libexec/qemu-bridge-helper.

     include/net/net.h:#define DEFAULT_BRIDGE_HELPER CONFIG_QEMU_HELPERDIR 
"/qemu-bridge-helper"

   As the C code already understands this path change, it's not a problem.

2. qemu_confdir = $prefix/etc/qeum moves. Affection: 
/usr/etc/qemu/target-x86_64.conf moves to 
/usr/lib/xen/etc/qemu/target-x86_64.conf

   Also seems the C code understand this path change.

3. It seems nothing will conflict with system qemu or qemu-kvm any more.

I think it's the right way to go.

I will do more test and report any issues I find.

Thanks,

Zhigang

Attachment: xen-tools-qemu-prefix.patch
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel