Re: [Xen-devel] [PATCH v6 08/19] x86/VPMU: Add public xenpmu.h

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

On 05/21/2014 03:19 AM, Dietmar Hahn wrote:
> Am Dienstag 13 Mai 2014, 11:53:22 schrieb Boris Ostrovsky:
> > Add pmu.h header files, move various macros and structures that will be
> > shared between hypervisor and PV guests to it.
> >
> > Move MSR banks out of architectural PMU structures to allow for larger sizes
> > in the future. The banks are allocated immediately after the context and
> > PMU structures store offsets to them.
> >
> > Signed-off-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
> > Reviewed-by: Dietmar Hahn <dietmar.hahn@xxxxxxxxxxxxxx>
> > Tested-by: Dietmar Hahn <dietmar.hahn@xxxxxxxxxxxxxx>
> It seems I didn't test right because calling
> # xl debug-keys q
> when running a HVM linux guest crashs the hypervisor.
> Please see below.

Yes, trying to dereference pointer that it explicitly set to NULL two 
lines above is not a particularly good idea.
Thanks for debugging this.

-boris


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel