Re: [Xen-devel] [PATCH v5 02/14] libxenstore.so: add support for systemd

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2014-05-21 at 15:35 +0100, Ian Campbell wrote:

> > +
> > +/*
> > + * We list stdin, stdout and stderr simply for documentation purposes
> > + * and to help our array size fit the number of expected sockets we
> > + * as sd_listen_fds() will return 5 for example if you set the socket
> > + * service with 2 sockets.
> 
> Please can we get rid of this list (which is bad enough in itself but
> the three spurious entries are ludicrous) and just
> #define SOCKET_RW_INDEX SD_LISTEN_FDS_START
> #define SOCKET_RO_INDEX SDL_LISTEN_FDS_START + 1
> etc and use those for lookups, as I described in
> <1399971222.11314.27.camel@xxxxxxxxxxxxxxxxxxxxxx>?

Also I thought that we decided that the mapping from the indexes here to
the functionality need to be documented as well, I'm not seeing that, at
least not based on a skim of the other subject lines in this series.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel