Re: [Xen-devel] [PATCH] x86, mce: Consolidate AMD mcheck initialization

[Aravind Gopalakrishnan <aravind.gopalakrishnan@xxxxxxx>]

On 5/22/2014 9:36 AM, Jan Beulich wrote:
> > > > On 21.05.14 at 23:06, <aravind.gopalakrishnan@xxxxxxx> wrote:
> > amd_k8.c did a lot of common work and very little K8
> > specific work. So merge init functions of amd_f10.c and
> > amd_k8.c and move it into the common amd_mcheck_init
> > handler. With that done, there is not much left in either
> > files, so fold all code into just one file - mce_amd.c
> >
> > While at it, update the comments regarding documentation
> > with correct URL's and revision numbers.
> >
> > Also, update copyright info.
> >
> > Signed-off-by: Aravind Gopalakrishnan <aravind.gopalakrishnan@xxxxxxx>
> > ---
> >   xen/arch/x86/cpu/mcheck/Makefile  |    2 -
> >   xen/arch/x86/cpu/mcheck/amd_f10.c |  118 ---------------------------
> >   xen/arch/x86/cpu/mcheck/amd_k8.c  |  117 ---------------------------
> >   xen/arch/x86/cpu/mcheck/mce_amd.c |  162 +++++++++++++++++++++++++++++++++----
> Content-wise this looks fine, but most of the additions to mce_amd.c
> need cleaning up coding-style-wise.
Hmm. Okay, I'll clean it up and resend.

Thanks,
-Aravind.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel