Re: [Xen-devel] [PATCH] tools/pygrub: Fix error handling if no valid partitions are found

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Jackson writes ("Re: [PATCH] tools/pygrub: Fix error handling if no valid 
partitions are found"):
> Andrew Cooper writes ("[PATCH] tools/pygrub: Fix error handling if no valid 
> partitions are found"):
> > If no partitions at all are found, pygrub never creates the name 'fs',
> > resulting in a NameError indicating the lack of fs, rather than a
> > RuntimeError explaining that no partitions were found.
> > 
> > Set fs to None right at the start, and use the pythonic idiom "if fs is 
> > None:"
> > to protect against otherwise valid values for fs which compare equal to
> > 0/False.
> 
> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Committed-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Backported to 4.4, 4.3, 4.2.  Will push shortly.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel