Re: [Xen-devel] [PATCH v8 13/13] gic_remove_from_queues: take a lock on the right vcpu

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Thu, 22 May 2014, Julien Grall wrote:
> Hi Stefano,
> 
> On 22/05/14 13:32, Stefano Stabellini wrote:
> > At the moment gic_remove_from_queues doesn't handle the case where the
> > guest kernel disables an irq on a different vcpu compared to the one
> > currently receiving the interrupt.
> > Make sure to take the right vcpu lock before removing the irq from
> > lr_queue.
> 
> I see the same issue with vgic_enable_irqs. We may inject to the wrong VCPU
> (i.e other than 0).
> 
> I think we should have the same case in vgic_enable_irqs.

I think it would make more sense to print a warning in
vgic_distr_mmio_write GICD_ITARGETSR rather than vgic_enable_irqs.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel