Re: [Xen-devel] [PATCH v8 08/14] xen/common: move memory_type_changed() function to common code

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Arianna,

On 25/05/14 11:51, Arianna Avanzini wrote:
> Currently, MTRR-related code is not available for the ARM architecture.
> Given that the memory_type_changed() function must be called also from
> common code, its invocation is currently ifdef'd out to be only compiled
> in on an x86 machine. This commit adds an empty stub for ARM, instead,
> also moving the function's definition to common code.
Hrmmm, MTRR doesn't have any sense on ARM, IIRC, this is only 
x86-related. So we should not expose this concept (i.e naming the 
include and source file) to the common architecture.
I would move the function declaration in xen/p2m*.h and add the stub for 
arm in arch/arm/p2m.c
Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel