Re: [Xen-devel] [PATCH v8 10/14] xen/common: move the memory_mapping DOMCTL hypercall to common code

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 26/05/14 11:07, Jan Beulich wrote:
> > > > On 25.05.14 at 18:42, <julien.grall@xxxxxxxxxx> wrote:
> > On 25/05/14 11:51, Arianna Avanzini wrote:
> > > +#include <xen/p2m-common.h>
> > > +
> > That would make more sense to include asm/p2m.h in xen/p2m-common.h
> > rather than the invert.
> >
> > This will avoid issue such as, a source file is trying to include
> > xen/p2m-common.h directly without adding asm/p2m.h before. This will
> > result to a compilation issue.
> >
> > Anyway, if the maintainers are fine with this solution, let's stick
> I actually asked for it to be done this way.
Ok, thanks. I was unable to find the email where you asked it.

In any case, I don't think we should expose mfn_t and _mfn to ARM. All 
the P2M interface used in common code, take an unsigned long in parameter.
Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel