[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 02/16] xen/arm: make mmio handlers domain specific



On 05/28/2014 03:05 PM, Stefano Stabellini wrote:
>>
>> Rather than moving a whole chunk of code, why can't you add forward
>> declaration for vgic_disk_mmio_{read,write}?
> 
> I think it would be OK either way

IHMO, it's more difficult to see what was change with this solution.

This serie is quite difficult to review (because of the number of line
changes). If we can avoid few of them it's better.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.