Re: [Xen-devel] [PATCH v6 8/9] xl: enable for specifying node-affinity in the config file

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On Wed, 2014-05-28 at 16:48 +0100, Ian Campbell wrote:
> On Wed, 2014-05-28 at 01:42 +0100, Dario Faggioli wrote:
> > in a similar way to how it is possible to specify vcpu-affinity.
> 
> $subject says node-affinity, but the body all seems to be dealing with
> vcpu affinity. (the "for" in $subj is redundant btw)
> 
Ok, thanks (for the "for" thing).

> OK, so having read a bit closer it seems that the node affinity is
> derived from the vcpu soft affinity, which makes sense. So the thing you
> actually specify is vcpu soft affinity which then gets turned into a
> node aff'ty internally. This would be better expressed in those terms in
> the commit message I think.
> 
> Before I dig too deeply into the code can you confirm that I am grasping
> the correct end of the stick.
> 
You are. Actually, the 'node-affinity' in the subject must be a remnant
for one of the first versions of the series that neither I or the
various rounds of review noticed. :-(

Anyway, it is true that the vcpu soft affinity may affect node affinity,
but this patch is all about "allowing the user to specify soft affinity
in the VM config file", and certainly both the subject and the commit
message should say so more clearly. I'll make it that way.

Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel