Re: [Xen-devel] [PATCH v4 11/16] xen/arm: calculate vgic irq rank based on register size

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 30/05/14 11:51, Vijay Kilari wrote:
> On Fri, May 30, 2014 at 4:06 PM, Julien Grall <julien.grall@xxxxxxxxxx> wrote:
> > With your explanation, I don't see any reason to replace all the dabt.size
> > != number by dat.size != DABT_*.
>    Two things are done here
>      (1)  In the code 'dabt.size != number' this number is always
> BYTE/HALF_WORD/WORD/DOUBLE
>        defined by hsr registers.  Instead of checking for hard coded
> values I used hsr defined values.
>      (2) The vgic_irq_rank also depends on the same hsr defined values
> to calculate irq rank.
>           Also, this make vgic_irq_rank generic as it takes register
> size as parameter to calculate irq rank instead
>            of hard coding to value 2 in previous patches
Please add theses explanations in the commit message. It's easier to 
understand the purpose of this patch with that.
Regards

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel