Re: [Xen-devel] [PATCH 3/7] mini-os: Moved events code under arch

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Thomas,

I'm not sure why you dropped everyone in cc (i.e Minios Maintainers &
Karim).

On 06/04/2014 05:06 PM, Thomas Leonard wrote:
> diff --git a/extras/mini-os/events.c b/extras/mini-os/events.c
> index 2da9b01..c2bda1a 100644
> --- a/extras/mini-os/events.c
> +++ b/extras/mini-os/events.c


[..]

> +
> +    arch_init_events();
>  }
>  
> +void arch_fini_events(void);

It's better to define the prototype in an header so the compiler can
check if the function declaration is actually matching the prototype.

This will avoid error if someone decide to modify the function
declaration without modifying the call-site...

I'm planning to send a patch to enable -Wmissing-prototypes on the
hypervisor side. It might be a good idea to enable -Wmissing-prototypes
on mini-os.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel