Re: [Xen-devel] [PATCH 2/7] mini-os: Tidied up code

[Anil Madhavapeddy <anil@xxxxxxxxxx>]

On 4 Jun 2014, at 17:22, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx> wrote:
>> diff --git a/extras/mini-os/gntmap.c b/extras/mini-os/gntmap.c
>> index 22ed450..f6ab3ad 100644
>> --- a/extras/mini-os/gntmap.c
>> +++ b/extras/mini-os/gntmap.c
>> @@ -38,6 +38,15 @@
>> #include <inttypes.h>
>> #include <mini-os/gntmap.h>
>> 
>> +//#define GNTMAP_DEBUG
>> +#ifdef GNTMAP_DEBUG
>> +#define DEBUG(_f, _a...) \
>> +    printk("MINI_OS(gntmap.c:%d): %s" _f "\n", __LINE__, __func__, ## _a)
> 
> Is the "MINI_OS" prefix useful?  I suspect not so much.

It's useful to distinguish the MiniOS console output from the application
libraries linked against it, since they all share the same console.

-anil

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel