Re: [Xen-devel] [PATCH 6/7] mini-os: Added rmb to xenbus code

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Thomas,

Thank you for the patch.

On 06/04/2014 05:06 PM, Thomas Leonard wrote:
> From: Karim Raslan <karim.allah.ahmed@xxxxxxxxx>
> 
> Signed-off-by: Karim Allah Ahmed <karim.allah.ahmed@xxxxxxxxx>
> [talex5@xxxxxxxxx: separated from big ARM commit]
> Signed-off-by: Thomas Leonard <talex5@xxxxxxxxx>
> ---
>  extras/mini-os/xenbus/xenbus.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/extras/mini-os/xenbus/xenbus.c b/extras/mini-os/xenbus/xenbus.c
> index d995020..8a99ee2 100644
> --- a/extras/mini-os/xenbus/xenbus.c
> +++ b/extras/mini-os/xenbus/xenbus.c
> @@ -450,6 +450,7 @@ xenbus_msg_reply(int type,
>      remove_waiter(w, req_info[id].waitq);
>      wake(current);
>  
> +    rmb();

Could you explain in the commit message why this rmb is necessary?

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel