Re: [Xen-devel] [PATCH 4/4] mini-os: Added FDT support on ARM

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2014-06-02 at 18:49 +0100, Thomas Leonard wrote:
> From: Karim Raslan <karim.allah.ahmed@xxxxxxxxx>

I don't see this patch in the second batch of 7 patches, even though
there appears to be some overlap? I'm a bit confused as to what the
relationship between this 4 patch series and that 7 patch one is.

If they are separate (but related) series then git send-email
--subject-prefix='PATCH FOO' where FOO is some short descriptive tag
might help. For a new revision you should also use --reroll-count=N to
add the vN to the subject too.

Anyway, on to this patch...

WRT the subject, "FDT support" seems to mean "add the libfdt library",
rather than say, "consume an fdt on boot" or anything? In that case I
think "import libfdt" would be a better title.

You also add memmove.c, which should be mentioned somewhere.

Since this is importing a bunch of code from elsewhere please can you
mention the provenance (tree, website, ideally a revision) of this code
in the commit message so we know where to look for updates etc in the
future.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel