Re: [Xen-devel] [PATCH v7 13/19] x86/VPMU: Add support for PMU register handling on PV guests

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

On 06/06/2014 04:26 PM, Andrew Cooper wrote:
>   }
>   
> +static void inject_trap(struct vcpu *v, unsigned int trapno)
> +{
> +    if ( has_hvm_container_domain(v->domain) )
> +        hvm_inject_hw_exception(trapno, 0);
> +    else
> +        send_guest_trap(v->domain, v->vcpu_id, trapno);
> +}
> +
> send_guest_trap() cant be used to send anything other than an nmi or
> mce, but you appear to be using it to try and send #PFs ?
Yes, this is wrong. I'll need to find right interface.

> >           {
> >           case MSR_TYPE_ARCH_CTRL:      /* MSR_P6_EVNTSEL[0,...] */
> >               mask = ~((1ull << 32) - 1);
> > -            if (msr_content & mask)
> > +            if ( msr_content & mask )
> It would be helpful not to mix large functional changes and code
> cleanup.  While I appreciate the cleanup, could it be moved to a
> different patch?  The same comment applies to several other patches as well.
I *think* this is the only instance of me doing this. I'll see if there 
are other places.
-boris

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel