[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v7 06/19] vmx: Merge MSR management routines

>>> On 06.06.14 at 19:40, <boris.ostrovsky@xxxxxxxxxx> wrote:
> +    ASSERT( (type == VMX_GUEST_MSR) || (type == VMX_HOST_MSR) );

As hinted at by Andrew already, I think you need to do a global
coding style cleanup pass through this series, making sure you
have (possibly among other things) spaces/parentheses where
they belong and, apart from ambiguous cases where it's a matter
of taste, none where none should be. The example here has too
many spaces - ASSERT, other than if/for/while, is not a keyword.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.