Re: [Xen-devel] [PATCH v4 03/16] xen/arm: make sgi handling generic

[Vijay Kilari <vijay.kilari@xxxxxxxxx>]

On Wed, May 28, 2014 at 7:40 PM, Stefano Stabellini
<stefano.stabellini@xxxxxxxxxxxxx> wrote:
> On Mon, 26 May 2014, vijay.kilari@xxxxxxxxx wrote:
>> From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>
>>
>> move all the hw specific sgi handling functionality
>> to one function and use it.
>>
>> Signed-off-by: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>
>>  void send_SGI_one(unsigned int cpu, enum gic_sgi sgi)
>> @@ -512,18 +531,18 @@ void send_SGI_self(enum gic_sgi sgi)
>>
>>      dsb(sy);
>>
>> -    GICD[GICD_SGIR] = GICD_SGI_TARGET_SELF
>> -        | sgi;
>> +    send_SGI(cpumask_of(smp_processor_id()), sgi, SGI_TARGET_SELF);
>>  }
>
> Given that the mask is unused in this case, I think it would be
> acceptable to pass NULL.

In GICv2 the mask is not used in some cases. However mask value is used
in GICv3. To make it generic mask value is always computed.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel