Re: [Xen-devel] [PATCH v4 05/16] xen/arm: use ioremap to map gic-v2 registers

[Vijay Kilari <vijay.kilari@xxxxxxxxx>]

On Wed, May 28, 2014 at 7:56 PM, Stefano Stabellini
<stefano.stabellini@xxxxxxxxxxxxx> wrote:
> On Mon, 26 May 2014, vijay.kilari@xxxxxxxxx wrote:
>> From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>
>>
>>  #include <asm/mmio.h>
>>  #include <asm/gic.h>
>>
>> -#define REG(n) (n/4)
>> +#define REG(n) (n)
>
> Is this macro actually needed still?
> We might as well get rid of it.

This is remove in another relevant patch

>>  /*
>>   * Returns rank corresponding to a GICD_<FOO><n> register for
>> @@ -63,7 +63,9 @@ static inline int REG_RANK_NR(int b, uint32_t n)
>>   */
>>  static struct vgic_irq_rank *vgic_irq_rank(struct vcpu *v, int b, int n)
>>  {
>> -    int rank = REG_RANK_NR(b, n);
>> +    int rank;
>> +    n = n >> 2;
>> +    rank = REG_RANK_NR(b, n);
>
> I would be consistent and change REG_RANK_NR instead of vgic_irq_rank.

 REG_RANK_NR is generic, instead parameter is changed

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel